packages/room/src/manager/event-wrapper.ts (2)

458-459: Refactor to avoid array mutation and improve performance.

The current implementation sorts the input array in place and uses pop() to find the maximum depth. This has two issues:

1. It mutates the caller's array, which is an unexpected side effect
2. Sorting is O(n log n) when finding the maximum is O(n)

Apply this diff to use Math.max instead:

-	const deepestDepth =
-		events.sort((e1, e2) => e1.depth - e2.depth).pop()?.depth ?? 0;
+	const deepestDepth = events.length > 0 
+		? Math.max(...events.map(e => e.depth))
+		: 0;

Alternatively, for a more concise version:

-	const deepestDepth =
-		events.sort((e1, e2) => e1.depth - e2.depth).pop()?.depth ?? 0;
+	const deepestDepth = Math.max(0, ...events.map(e => e.depth));

---

460-462: Consider adding a clarifying comment.

The conditional depth update using <= is correct for supporting incremental addPrevEvents calls, where depth should increase with each batch of predecessors but never decrease. However, the reasoning might not be immediately obvious to future readers.

Consider adding a brief comment:

+	// Update depth if any predecessor is deeper or equal (allows incremental predecessor additions)
 	if (this.rawEvent.depth <= deepestDepth) {
 		this.rawEvent.depth = deepestDepth + 1;
 	}

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.